-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Diff against the right remote + branch in Regressions.yml
- Regression Test new micro benchmark
#12106
[CI] Diff against the right remote + branch in Regressions.yml
- Regression Test new micro benchmark
#12106
Conversation
Why are we doing only on pull request? What was wrong with |
As said before, there is no way to know what branch this has to diff against for a push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true, forgot about that detail. LGTM!
I just realized looking at this: why do we have the push block at all? (I know why we used to have it, but I think it can be probably just removed everywhere) |
After merging and getting a merge conflict when propagating this to feature - I wonder if there is any added functionality here over what was already done in #11762 |
I'll check and submit a PR to fix main and or master |
I've left feature with only #11762 for now, feel free to open a new PR to feature with whichever changes are relevant there. |
This PR aims to fix CI of PRs made to
feature
:By only running this job if the event is a PR, and diffing against the target branch instead of hardcoding this to
main