Move excel extension out of tree #12123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a CI failure that needs looking at, |
carlopi
added
Ready To Merge
Ready For Review
and removed
CI Failure
Ready To Merge
labels
|
Fixed minor merge conflict (extension updated touched the same file), git is unsure on what to do on modifying a deleted file, bumped to current duckdb_excel main. |
|
Failures on nightly job are expected, and present also on main. |
|
Thanks! |
Mytherin
added
the
Needs Documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of excel folder (with snapshot of history) is at duckdb/duckdb_excel. Needs a REAME / some polishing, but it should be already functional for what regards duckdb's CI.