optim egctl get httpserver to show port and https #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1248 +/- ##
==========================================
+ Coverage 79.48% 79.50% +0.01%
==========================================
Files 152 152
Lines 17295 17295
==========================================
+ Hits 13747 13750 +3
+ Misses 2879 2877 -2
+ Partials 669 668 -1 ☔ View full report in Codecov by Sentry. |
zhao-kun
reviewed
Mar 26, 2024
cmd/client/resources/object.go
Outdated
| for namespace, metas := range metas { | ||
| if namespace == DefaultNamespace { | ||
| continue | ||
| } | ||
| for _, meta := range metas { | ||
| table = append(table, []string{meta.Name, meta.Kind, namespace, getAgeFromMetaSpec(meta)}) | ||
| if meta.Kind == "HTTPServer" { |
There was a problem hiding this comment.
It is common for each object to have its representation, so a well-designed framework is needed to handle the difference.
There was a problem hiding this comment.
updated, please check
zhao-kun
reviewed
Mar 27, 2024
cmd/client/resources/spec.go
Outdated
| } | ||
|
|
||
| // ObjectSpec is the interface of the object spec. | ||
| type ObjectSpec interface { |
There was a problem hiding this comment.
It's best to give a meaningful name to intuitively describe its usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.