Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add keepAlive and layouts #98

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

faukwaa
Copy link

@faukwaa faukwaa commented May 14, 2024

No description provided.

Copy link

netlify bot commented May 14, 2024

Deploy Preview for vue3-vant-mobile ready!

Name Link
🔨 Latest commit 44f4e27
🔍 Latest deploy log https://app.netlify.com/sites/vue3-vant-mobile/deploys/6642e7002ab5640008c259d0
😎 Deploy Preview https://deploy-preview-98--vue3-vant-mobile.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99
Accessibility: 97
Best Practices: 100
SEO: 92
PWA: 100
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@CharleeWa
Copy link
Collaborator

布局会在 v3 重新考虑,此 PR 仍处于开放状态。非常感谢。

@faukwaa
Copy link
Author

faukwaa commented May 15, 2024

布局会在 v3 重新考虑,此 PR 仍处于开放状态。非常感谢。

v3 的布局会往哪个方向考虑,可以参与 v3 的开发

@CharleeWa
Copy link
Collaborator

v3 的布局会往哪个方向考虑,可以参与 v3 的开发

欢迎参与。当时考虑的布局优化不会改动太大。在不影响路由动画的前提下,去掉每个页面的 Container 组件。

@CharleeWa
Copy link
Collaborator

这个 PR 的思路很不错。当时也用了 vite-plugin-vue-layouts 插件做文件路由的布局,但是在做 KeepAlive 时遇到了无法工作的问题就给去掉了,取而代之的是在 App.vue 主入口做简单布局。其实我想的很简单,无论是开发者使用嵌套文件路由做布局,还是组件插槽,都还是简单的。并不想提供太多封装和复杂性。后边主推 nuxt3-vant-mobile。这些特性它天然支持。

@faukwaa
Copy link
Author

faukwaa commented May 15, 2024

这个 PR 的思路很不错。当时也用了 vite-plugin-vue-layouts 插件做文件路由的布局,但是在做 KeepAlive 时遇到了无法工作的问题就给去掉了,取而代之的是在 App.vue 主入口做简单布局。其实我想的很简单,无论是开发者使用嵌套文件路由做布局,还是组件插槽,都还是简单的。并不想提供太多封装和复杂性。后边主推 nuxt3-vant-mobile。这些特性它天然支持。

我看了 v3 的分支,不是 nuxt 的,是别的仓库吗

@CharleeWa
Copy link
Collaborator

我看了 v3 的分支,不是 nuxt 的,是别的仓库吗

这个仓库 https://github.com/easy-temps/nuxt3-vant-mobile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants