Fixing search to elevate exact matches #1162
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
There was a problem hiding this comment.
Did you test if this introduces noticeable lag on larger communities (e.g. lethal company)? There have been some search performance issues before, the main problem is how iteration based everything to do with the mod list is atm (overall, not just this PR change).
This looks like it shouldn't cause too significant issues, but perhaps it'd be worth restricting it to only run when the result set is already somewhat narrowed down? It should also be fairly trivial to do this in a single iteration rather than two like it does now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This always super annoys me when I'm searching for a specific mod with a name I already know. This reorders the exact matches to the top of the list.