Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support zstd compression #5176

Merged
merged 3 commits into from May 18, 2024
Merged

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Apr 1, 2024

Motivation

Netty supports zstd compression.

Google Chrome recently added support for zstd
https://www.phoronix.com/news/Zstd-1.5.6-Zstandard

Conformance

You should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines

@vietj
Copy link
Member

vietj commented Apr 2, 2024

can you create a test for this based on a subclass of HttpCompressionTestBase like other compression schemes have ?

@vietj
Copy link
Member

vietj commented Apr 3, 2024

@sullis test is not passing, can you investigate ?

@sullis
Copy link
Contributor Author

sullis commented Apr 4, 2024

@sullis test is not passing, can you investigate ?

I believe we need to wait for Netty 4.1.109. The Netty team recently updated HttpContentDecompressor, and the change will be included in the 4.1.109 release.

I am going to convert this PR to "draft" for now.

@sullis sullis marked this pull request as draft April 4, 2024 14:43
@sullis
Copy link
Contributor Author

sullis commented Apr 4, 2024

in my local workspace, I upgraded to a Netty snapshot release ( Netty 4.1.109.Final-SNAPSHOT).

Http1xZstdCompressionTest passes with the Netty snapshot.

@vietj
Copy link
Member

vietj commented Apr 5, 2024

ok then it's in standby for now

@vietj
Copy link
Member

vietj commented May 17, 2024

@sullis can you update the PR since now vertx depends on Netty 4.1.109.Final ?

@sullis
Copy link
Contributor Author

sullis commented May 17, 2024

@sullis can you update the PR since now vertx depends on Netty 4.1.109.Final ?

Awesome! I just pushed an update. Let's wait for the CI build to finish 😎

@sullis sullis marked this pull request as ready for review May 17, 2024 15:54
@sullis
Copy link
Contributor Author

sullis commented May 17, 2024

CI build looks good.

@vietj vietj merged commit d138ff3 into eclipse-vertx:master May 18, 2024
7 checks passed
@vietj vietj added this to the 5.0.0 milestone May 18, 2024
@sullis sullis deleted the sean/zstd-compression branch May 18, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants