-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge protocol_changes
into interests
#1033
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Revert "fix(zenoh-runtime): zenoh-c DLL crash in `libc::atexit` handler (eclipse-zenoh#972)" This reverts commit 274166d. * ci: disable atexit cleanup on Windows
- fix z_payload_shm example
…-zenoh#995) * fix: set the minimal sleep interval to 17ms on windows * fixup! fix: set the minimal sleep interval to 17ms on windows * fixup! fix: set the minimal sleep interval to 17ms on windows
* ACL does not intercept messages with no key_expr * Update DEFAULT_CONFIG.json5
* fix bug in acl config validation * Update ACL config error messages * Apply suggestions from code review Co-authored-by: oteffahi <70609372+oteffahi@users.noreply.github.com> * Update zenoh/src/net/routing/interceptor/authorization.rs Co-authored-by: oteffahi <70609372+oteffahi@users.noreply.github.com> * Fix mistake in ACL config error message * Allow empty interfaces and flows in config * Add warning logs for implicit wildcard ACL config * Fix linting * Add support for undefined interfaces and flows lists This reverts commits a2db2d7 5008e38 e204f2d. * Error out when ACL cannot be enabled --------- Co-authored-by: oteffahi <70609372+oteffahi@users.noreply.github.com> Co-authored-by: Luca Cominardi <luca.cominardi@gmail.com> Co-authored-by: Oussama Teffahi <oussama.teffahi@zettascale.tech>
Conflicts: examples/examples/z_payload_shm.rs examples/examples/z_sub_shm.rs zenoh/tests/payload.rs
Conflicts: examples/examples/z_get_shm.rs examples/examples/z_queryable_shm.rs
* chore: renamed no_mangle feature to dynamic_plugin Signed-off-by: gabrik <gabriele.baldoni@gmail.com> * fix: wrong find and replace fixed Signed-off-by: gabrik <gabriele.baldoni@gmail.com> --------- Signed-off-by: gabrik <gabriele.baldoni@gmail.com>
…-zenoh#1009) * Fixed performance issue with contiguous (eclipse-zenoh#1008) * fixed format issue slipped in when fixing (eclipse-zenoh#1008) * Update commons/zenoh-buffers/src/lib.rs Co-authored-by: Luca Cominardi <luca.cominardi@gmail.com> --------- Co-authored-by: Luca Cominardi <luca.cominardi@gmail.com>
In https://github.com/eclipse-zenoh/ci/pull/129/files, the action to release docker images was changed to use an image attribute instead of tags, so we can properly tag latest and nightly releases.
* fix: remove the unsound atexit cleanup * fix: refine the unsafe function
* test: use the minimal setting * test: use a shorter timeout * fix: re-introduce the nextest timeout * test: add the debugging info * test: disable the windows ci * Fix deadlock in session::close * test: do not retry * chore: clean up all the auxiliary files --------- Co-authored-by: OlivierHecart <olivier.hecart@adlinktech.com>
…improve scalability (eclipse-zenoh#814) * Router implements interests protocol for clients * Send WireExpr in UndeclareSubscriber/UndeclareQueryable to clients for pico * Fix WireExprExt M flag encoding/decoding * Fix decl_key * Clients send all samples and queries to routers and peers * Avoid self declaration loop on interest * Fix query/replies copy/paste bugs * Peers implement interests protocol for clients * Don't send WireExpr in UndeclareSubscriber/UndeclareQueryable to clients * Add client writer-side filtering (eclipse-zenoh#863) * Add client writer-side filtering * Reimplement liveliness with interests * Fix writer-side filtering before receiving FinalInterest * Fix pubsub interest based routing after router failover * Declare message can be Push/Request/RequestContinuous/Response * Address review comments * Remove F: Future flag from DeclareInterest * cargo fmt --all * Remove unused Interest flags field * Update doc * Remove unneeded interest_id field * Update commons/zenoh-protocol/src/network/declare.rs * Remove unused UndeclareInterest * Implement proper Declare Request/Response id correlation * Add new Interest network message * Update doc * Update codec * Fix stable build * Fix test_acl * Fix writer side filtering * Add separate functions to compute matching status * Fix unstable imports * Remove useless checks --------- Co-authored-by: Luca Cominardi <luca.cominardi@gmail.com>
* fix: Add step to update Stable Rust toolchain When GitHub runners images update their Rust stable channel, this update may not be propagated to all runners at the same time. In such a case CI jobs will use different Rust versions which leads to inconsistent behavior. * fix: Apply clippy lints * fix: Restore deleted `utfdbg` macro * fix: Workaround `clippy:assigning_clones` in `KeyExprFuzzer`
SHM refine: Allocation API
* Router implements interests protocol for clients * Send WireExpr in UndeclareSubscriber/UndeclareQueryable to clients for pico * Fix WireExprExt M flag encoding/decoding * Fix decl_key * Clients send all samples and queries to routers and peers * Avoid self declaration loop on interest * Fix query/replies copy/paste bugs * Peers implement interests protocol for clients * Don't send WireExpr in UndeclareSubscriber/UndeclareQueryable to clients * Add client writer-side filtering (eclipse-zenoh#863) * Add client writer-side filtering * Reimplement liveliness with interests * Fix writer-side filtering before receiving FinalInterest * Fix pubsub interest based routing after router failover * Declare message can be Push/Request/RequestContinuous/Response * Address review comments * Remove F: Future flag from DeclareInterest * cargo fmt --all * Remove unused Interest flags field * Update doc * Remove unneeded interest_id field * Update commons/zenoh-protocol/src/network/declare.rs * Remove unused UndeclareInterest * Implement proper Declare Request/Response id correlation * Add new Interest network message * Update doc * Update codec * Fix stable build * Fix test_acl * Fix writer side filtering * Add separate functions to compute matching status * Fix unstable imports * Remove useless checks * Don't apply open session delay in client mode * Add open_delay test * Peers don't apply writer side filtering until FinalInterest is received * Don't wait for full scouting delay when peers connected all configured connect endpoints * Increase scouting delay and decrease api open delay * Wait for gossip and related connections attempts before returning to open * Remove random backoff for p2p * Fix memory leak * Remove API_OPEN_DELAY * Don't apply any scouting delay when multicast disabled and no configured connect/endpoints * Sleep for scouting/delay in router and linkstate peer modes --------- Co-authored-by: Luca Cominardi <luca.cominardi@gmail.com>
interests branch has already been squashed and merged into protocol_changes: cfb86a8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge conflicts only involved import statements.