Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpi: add uart device_path #842

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Mani-Sadhasivam
Copy link
Contributor

Currently there is no device_path registered for UART in Raspberry Pi
source. This will hinder the working of UART driver in mraa.

So, register the device_path with '/dev/serial0' as most of the
raspbian images make this as a soft link to real UART port by
default.

Tested-on: Raspberry pi 3 model B

Signed-off-by: Manivannan Sadhasivam manivannan.sadhasivam@linaro.org

Copy link

@kvkdileep kvkdileep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on raspberry pi 3
the mraa-uart list is listing the uart bus

@alext-mkrs
Copy link
Contributor

The change is technically trivial and looks ok to me, but are you sure the path is the same on RasPi 1 & 2, in addition to 3? Quick googling gives me this may be a RasPi 3 thing and on older versions the port was either /dev/ttyAMA0 or /dev/ttyS0. I don't have any of those to check, unfortunately.

On the other hand, if it wasn't there at all, it didn't work anyway, so having a wrong one would do no harm.

Currently there is no device_path registered for UART in Raspberry Pi
source. This will hinder the working of UART driver in mraa.

So, register the device_path with '/dev/ttyS0' for all the raspberry
pi models except Rpi3. For Rpi3 'dev/serial0' is used as most of the
raspbian images make this as a symlink to _real_ UART port by
default.

Tested-on: Raspberry pi 3 model B

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
@Mani-Sadhasivam
Copy link
Contributor Author

@alext-mkrs I assumed that /dev/serial0 exists for all Rpi models!

Changed the serial port to /dev/ttyS0 for all models except Rpi3. This port is used as general purpose UART while /dev/ttyACM0 is used for console. Also, /dev/serial0 is used for Rpi3.

@Mani-Sadhasivam
Copy link
Contributor Author

@kvkdileep Can you do a quick test now?

@kvkdileep
Copy link

kvkdileep commented Nov 15, 2017

@Mani-Sadhasivam spare me some time, i will test it with sensor having uart interface

@arfoll
Copy link
Contributor

arfoll commented Nov 17, 2017

@kvkdileep have you had a chance to test this?

@arfoll
Copy link
Contributor

arfoll commented Jan 4, 2018

@kvkdileep did this work?

@alext-mkrs
Copy link
Contributor

alext-mkrs commented Jan 16, 2018

@kvkdileep, are you still up to checking this one out? That's the last step before merging as everything else looks ok (Travis failure is unrelated to the change contents).

@Propanu
Copy link
Contributor

Propanu commented Apr 30, 2018

If this was tested I'm OK to merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants