Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle exceptions correctly if native function throws exception #896

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

SergeyKleyman
Copy link
Contributor

@SergeyKleyman SergeyKleyman commented Mar 17, 2023

Zend's call_user_function returns failure when EG(exception) != NULL so we cannot call instrumentation post-hook if the original handler exited by exception.

@SergeyKleyman SergeyKleyman self-assigned this Mar 17, 2023
@elastic-apm-tech elastic-apm-tech added this to In Progress in APM-Agents (OLD) Mar 17, 2023
Before this fix MemoryTracker reported all the allocated blocks even when the leak was detected for the request-scoped allocations
…e than once

Fixed memory leak for the case when legacy PHP error is triggered more than once - pointer to allocated memory for previous error data is overwritten without freeing it first.
@SergeyKleyman SergeyKleyman marked this pull request as ready for review March 22, 2023 10:59
@v1v
Copy link
Member

v1v commented Feb 9, 2024

run docs-build

@intuibase intuibase changed the title Skip post-hook if instrumented function has thrown Handle exceptions correctly if native function throws exception Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
APM-Agents (OLD)
  
In Progress
Development

Successfully merging this pull request may close these issues.

None yet

3 participants