[Box] add logs

[moxarth-elastic]

Part Of #2299

Adding more logs in Box connector.

Log file: https://drive.google.com/file/d/1TnFFvRBvMb2wGKQWz9N6dVkQtXUO7AIK/view?usp=drive_link

Checklists

Pre-Review Checklist

• this PR does NOT contain credentials of any kind, such as API keys or username/passwords (double check config.yml.example)
• this PR has a meaningful title
• this PR links to all relevant github issues that it fixes or partially addresses
• if there is no GH issue, please create it. Each PR should have a link to an issue
• this PR has a thorough description
• Tested the changes locally
• Added a label for each target release version (example: v7.13.2, v7.14.0, v8.0.0)

[artem-shelkovnikov]

From the log lines:

1. "Successfully connected to Box" should be DEBUG, failure to connect should be WARN
2. "Fetching files and folders recursively for folder ID: 0" - can we have folder path instead of id?
3. "Retrieving access token from the cache" we should delete, it spams too much. Instead, we should just output in DEBUG when we're fetching token not from the cache, but from Box
4. "Making a GET call for url: /2.0/folders/258475338133/items with params: {'fields': 'name,modified_at,size,type,sequence_id,etag,created_at,modified_at,content_created_at,content_modified_at,description,created_by,modified_by,owned_by,parent,item_status', 'offset': 0, 'limit': 1000}" - can we just make it "Calling GET {host}/2.0/folders/258475338133/items?fields=name,modified_at,size,type,...&offset=0&limit=1000"? This will help a lot if we need to emulate this specific query and you can just copy-paste url into postman or curl?

[navarone-feekery]

I think having "0" be defined with a variable name root_folder (basically as it was before) is better for clarity. Someone without understanding of box will not know what 0 is at first glance. Could you revert that please?

[navarone-feekery]

I think already_processed_ids was clearer than stored_id. If I look at this code later, I will think "why is it stored?"

If you want to shorten the variable name, perhaps seen_ids is better?

[moxarth-elastic]

buildkite test this

[navarone-feekery]

Looking good, just left one final change request

[navarone-feekery]

I think query_string should only built when debug logs are enabled. How it is here, this string is being built every run even though it isn't used unless debug logs are enabled. It's minor, but every bit counts when looking at performance.

This could be moved to a func elsewhere called something like debug_query_string and could be called in-line like this:

Suggested change

	query_string = (
	"&".join(f"{key}={value}" for key, value in params.items())
	if params
	else ""
	)
	self._logger.debug(f"Calling GET {url}?{query_string}")
	self._logger.debug(f"Calling GET {url}?{debug_query_string(params)}")