Add option to track array source in ObjectMapper #108496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fix/synthetic-source/array
kkrik-es
added
>non-issue
Team:StorageEngine
:StorageEngine/Mapping
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
martijnvg
reviewed
May 13, 2024
| @@ -242,6 +250,9 @@ protected static boolean parseObjectOrDocumentTypeProperties( | |||
| } else if (fieldName.equals("enabled")) { | |||
| builder.enabled(XContentMapValues.nodeBooleanValue(fieldNode, fieldName + ".enabled")); | |||
| return true; | |||
| } else if (fieldName.equals("track_array_source")) { | |||
There was a problem hiding this comment.
Maybe turn the name into a constant? I think store_array_source maybe be better. This name is inline with the store param and the source mode when we store the source.
Maybe store_source is better if we like to extend this functionally for other fields as well?
There was a problem hiding this comment.
store_array_source sounds good. I think it's better to avoid a catch-all param since each one may have substantial impact on storage. We can add one in the future if we prefer so.
kkrik-es
added
the
auto-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new option,
store_array_source, will be used to control when to track the source for arrays of objects within objects that have this option set. This only applies to indexes with synthetic source mode.Related to #90708