Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESQL: Fix logging test #108520

Merged
merged 3 commits into from May 13, 2024
Merged

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented May 10, 2024

This fixes the logging tests when run against multiple nodes.

Closes #108367

This fixes the logging tests when run against multiple nodes.

Closes elastic#108367
@nik9000 nik9000 added >test Issues or PRs that are addressing/adding tests :Analytics/ES|QL AKA ESQL v8.15.0 labels May 10, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label May 10, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Copy link
Contributor

@luigidellaquila luigidellaquila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I got the intention right, it needs a little fix; apart from that, it looks good.
Thanks!

@nik9000
Copy link
Member Author

nik9000 commented May 13, 2024

If I got the intention right, it needs a little fix; apart from that, it looks good.

oops. Those all make sense. I'll get them in. First I'll make sure the serverless build fails without them. I mean, it should, but if it doesn't I'll be confused.

Co-authored-by: Luigi Dell'Aquila <luigi.dellaquila@gmail.com>
@nik9000 nik9000 added the auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label May 13, 2024
@elasticsearchmachine elasticsearchmachine merged commit 1d62a7b into elastic:main May 13, 2024
16 checks passed
@nik9000 nik9000 deleted the esql_check_all_logs branch May 13, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests test-update-serverless v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] RestEsqlIT testDoLogWithDebug {p0=SYNC} failing on serverless
4 participants