Make MockLogAppender itself Releasable #108526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing uses of MockLogAppender first construct an appender, then call capturing on the instance in a try-with-resources block. This commit adds a new method, capture, which creates an appender and sets up the capture the the same time. The intent is that this will replace the existing capturing calls, but there are too many to change in one PR.
rjernst
added
>test
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
elasticsearchmachine
added
v8.15.0
Team:Core/Infra
rjernst
force-pushed
the
test/mock_appender_try
branch
from
63d8832
to
23a6776
Compare
ldematte
reviewed
May 13, 2024
| /** | ||
| * Adds the list of class loggers to this {@link MockLogAppender}. | ||
| * | ||
| * Stops and runs some checks on the {@link MockLogAppender} once the returned object is released. | ||
| */ | ||
| public Releasable capturing(Class<?>... classes) { |
There was a problem hiding this comment.
I'm confused: you stated in the description that you wanted to replace capturing gradually (hence the non-provate MockLogAppender ctor), but here you are removing them. What am I missing?
There was a problem hiding this comment.
They still exist, just above this. The diff shows weird because the javadoc is moved to the new method.
There was a problem hiding this comment.
Ah! Got it. Yes, the diff was confusing.
ldematte
approved these changes
May 13, 2024
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
May 15, 2024
rjernst
added a commit
that referenced
this pull request
May 16, 2024
nicktindall
pushed a commit
to nicktindall/elasticsearch
that referenced
this pull request
May 17, 2024
parkertimmins
pushed a commit
to parkertimmins/elasticsearch
that referenced
this pull request
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing uses of MockLogAppender first construct an appender, then call capturing on the instance in a try-with-resources block. This commit adds a new method, capture, which creates an appender and sets up the capture the the same time. The intent is that this will replace the existing capturing calls, but there are too many to change in one PR.