Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.14] Fix integer overflow in native scalar quantizer #108535

Merged
merged 3 commits into from May 12, 2024
Merged

[8.14] Fix integer overflow in native scalar quantizer #108535

merged 3 commits into from May 12, 2024

Conversation

jimczi
Copy link
Contributor

@jimczi jimczi commented May 11, 2024

Backport #108493

@jimczi @ChrisHegarty @elasticmachine
Fix integer overflow in native scalar quantizer (elastic#108493)
017e4f2 
Offsets in memory segments should be computed as longs to avoid integer overflow on large segments.

---------

Co-authored-by: ChrisHegarty <chegar999@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@jimczi jimczi added >bug backport auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Search/Vectors Vector search v8.14.1 test-arm Pull Requests that should be tested against arm agents labels May 11, 2024
@ChrisHegarty
Copy link
Contributor

@elasticmachine update branch

@ChrisHegarty
Copy link
Contributor

@elasticmachine update branch

ChrisHegarty
ChrisHegarty approved these changes May 12, 2024
View reviewed changes
Copy link
Contributor

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticsearchmachine elasticsearchmachine merged commit d0a388d into elastic:8.14 May 12, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisHegarty ChrisHegarty ChrisHegarty approved these changes

Assignees
No one assigned
Labels
auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport >bug :Search/Vectors Vector search test-arm Pull Requests that should be tested against arm agents v8.14.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jimczi @ChrisHegarty @elasticsearchmachine @elasticmachine