[O11y][HAProxy] Enable secret for the password field, update format version and add dashboard-level filters. #9897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Benchmarks reportTo see the full report comment with |
|
Can you add screenshots for the filter-related changes? |
ritalwar
reviewed
May 27, 2024
packages/haproxy/manifest.yml
Outdated
| description: Collect logs and metrics from HAProxy servers with Elastic Agent. | ||
| type: integration | ||
| icons: | ||
| - src: /img/logo_haproxy.svg | ||
| title: logo HAProxy | ||
| size: 32x32 | ||
| type: image/svg+xml | ||
| format_version: 1.0.0 | ||
| license: basic | ||
| format_version: 3.0.0 |
There was a problem hiding this comment.
The format version should be upgraded to 3.0.2 for secret enablement change.
ritalwar
reviewed
May 27, 2024
packages/haproxy/changelog.yml
Outdated
| @@ -1,4 +1,9 @@ | |||
| # newer versions go on top | |||
| - version: "1.12.0" | |||
| changes: | |||
| - description: Update format version and enable secrets for sensitive fields. For more details, refer https://www.elastic.co/guide/en/fleet/current/agent-policy.html#agent-policy-secret-values | |||
There was a problem hiding this comment.
Suggested change
| - description: Update format version and enable secrets for sensitive fields. For more details, refer https://www.elastic.co/guide/en/fleet/current/agent-policy.html#agent-policy-secret-values | |
| - description: Enable secret for the `password` field and add dashboard-level filters. |
We don't need to add the link here since it's already shown in Kibana, but I'm okay with keeping it if you prefer. We didn't do this in other secret enablement PRs.
It is already present in the screenshot section of the description. |
💚 Build Succeeded
History
|
|
ritalwar
changed the title
ritalwar
approved these changes
May 28, 2024
devamanv
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
3.0.2.8.12.0.Checklist
changelog.ymlfile.Screenshots
HAProxy