Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Apache.Access] Added response_time in microseconds as a field to apache access data_stream #9913

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Alphayeeeet
Copy link
Contributor

@Alphayeeeet Alphayeeeet commented May 17, 2024

Added response_time in microseconds as a field to apache access data_stream

The response_time was added as an optional log parameter in a separate grok pattern, so that it is fully backwards compatible. The new log format, which includes %D was documented in the README as well as the newly added field.

The reason behind this, is to allow response_time to be collected (as in our environment we need it) and therefore a dashboard which uses that could maybe be added in the future.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

and re-generated test specs
@Alphayeeeet Alphayeeeet requested a review from a team as a code owner May 17, 2024 10:35
@Alphayeeeet
Copy link
Contributor Author

Please label the PR as an enhancement as I have no permissions to set labels.

@Alphayeeeet Alphayeeeet changed the title Added response_time in microseconds as a field to apache access data_stream [Apache.Access] Added response_time in microseconds as a field to apache access data_stream May 17, 2024
@aliabbas-elastic
Copy link
Contributor

/test

@aliabbas-elastic
Copy link
Contributor

/test

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

Copy link
Contributor

@aliabbas-elastic aliabbas-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this PR but we'll need one more round of review from someone in @elastic/obs-infraobs-integrations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:Apache
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants