[Entity Analytics] Simplify telemetry tests, add empty index check and logging #183915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#6059[❌] x-pack/test/security_solution_api_integration/test_suites/entity_analytics/risk_engine/trial_license_complete_tier/configs/ess.config.ts: 173/200 tests passed. |
hop-dev
changed the title
|
@elasticmachine merge upstream |
hop-dev
added
release_note:skip
|
Pinging @elastic/security-entity-analytics (Team:Entity Analytics) |
machadoum
reviewed
May 22, 2024
...tion/test_suites/entity_analytics/risk_engine/trial_license_complete_tier/telemetry_usage.ts
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @hop-dev |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#6066[✅] x-pack/test/security_solution_api_integration/test_suites/entity_analytics/risk_engine/trial_license_complete_tier/configs/serverless.config.ts: 100/100 tests passed. |
machadoum
approved these changes
May 22, 2024
kibanamachine
added
v8.15.0
backport:skip
rshen91
pushed a commit
to rshen91/kibana
that referenced
this pull request
May 30, 2024
…d logging (elastic#183915) ## Summary Closes elastic#182881 Not sure what went wrong with this test btu I did find the structure slightly more complicated than needed, I have moved the beforeEach data loading into the test body and removed the describe blocks. I have also removed the afterEach, we really shouldnt need to delete the data twice 😓 I have done [a 200 flaky test run](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6059#018f9b55-2231-4655-ab35-c6f26aa49720) 🟠 173 succeeded and 2 failed due to a bootstrap issue which caused the others not to run. --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #182881
Not sure what went wrong with this test btu I did find the structure slightly more complicated than needed, I have moved the beforeEach data loading into the test body and removed the describe blocks.
I have also removed the afterEach, we really shouldnt need to delete the data twice 😓
I have done a 200 flaky test run 🟠 173 succeeded and 2 failed due to a bootstrap issue which caused the others not to run.