-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Connectors] Use Connector API to cancel all syncs #183924
[Connectors] Use Connector API to cancel all syncs #183924
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Summary
Use Connector API to cancel all sync jobs for a connector. Slightly more overhead since we need to cancel each job separately but this is the only cancel endpoint we have as of now.
The ES logic handles
pending
,suspended
andrunning
jobs in a same way as kibana did, logic reference: https://github.com/elastic/elasticsearch/blob/e77613cdfc5a2b5598ff125b5881d87f9369c867/x-pack/plugin/ent-search/src/main/java/org/elasticsearch/xpack/application/connector/syncjob/ConnectorSyncJobIndexService.java#L264ES logic also handles status transitions to guard against e.g. cancelling already completed syncs
Valdiation
Tested locally
Checklist
Delete any items that are not applicable to this PR.