[Search] [Chat Playground] handle when the ActionLLM is not a ChatModel #183931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joemcelroy
added
release_note:skip
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
Samiul-TheSoccerFan
approved these changes
May 21, 2024
| @@ -166,6 +167,15 @@ class ConversationalChainFn { | |||
| }); | |||
| } | |||
| }, | |||
| // callback for prompt based models (Bedrock uses ActionsClientLlm) | |||
| handleLLMStart(llm, input, runId, parentRunId, extraParams, tags, metadata) { | |||
There was a problem hiding this comment.
Same lint issue?
Comment on lines
+68
to
+72
| const llm = isChatModel | ||
| ? new FakeListChatModel({ | ||
| responses, | ||
| }) | ||
| : new FakeListLLM({ responses }); |
There was a problem hiding this comment.
Do you know if the lint is correct here? Looks like two different styles for two functions.
There was a problem hiding this comment.
i would say so otherwise CI would complain. Looks like its based on line width.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Two action based LLMs:
ActionsClientChatOpenAIandActionsClientLlm.ActionsClientChatOpenAIis based on the ChatModel LLM,ActionsClientLlmis a prompt based model. The callbacks are different when using a ChatModel vs LLMModel. Token count is done on the ChatModelStart callback. This meant the token count didn't happen for LLMModel based actions (Bedrock).To fix i listen on both callbacks.
Checklist
Delete any items that are not applicable to this PR.