-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[search] Make ISearchOptions compatible with DataViewLazy #183939
[search] Make ISearchOptions compatible with DataViewLazy #183939
Conversation
/ci |
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, simple type check, so I didn't test
/ci |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
References to deprecated APIs
History
To update your PR or re-run it, just comment with: cc @mattkime |
…3939) ## Summary Simply changing the type on `ISearchOptions` to work with DataViewLazy. Nothing that uses `ISearchOption` uses the field list so these are type only changes Part of elastic#183694
Summary
Simply changing the type on
ISearchOptions
to work with DataViewLazy. Nothing that usesISearchOption
uses the field list so these are type only changesPart of #183694