Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[search] Make ISearchOptions compatible with DataViewLazy #183939

Merged
merged 3 commits into from
May 23, 2024

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented May 21, 2024

Summary

Simply changing the type on ISearchOptions to work with DataViewLazy. Nothing that uses ISearchOption uses the field list so these are type only changes

Part of #183694

@mattkime
Copy link
Contributor Author

/ci

@mattkime mattkime self-assigned this May 21, 2024
@mattkime mattkime added Feature:Search Querying infrastructure in Kibana Feature:Data Views Data Views code and UI - index patterns before 8.0 Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) labels May 21, 2024
@mattkime mattkime changed the title make search options data view lazy compatible [search] Make ISearchOptions compatible with DataViewLazy May 21, 2024
@mattkime mattkime marked this pull request as ready for review May 21, 2024 17:57
@mattkime mattkime requested a review from a team as a code owner May 21, 2024 17:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@mattkime mattkime added the release_note:skip Skip the PR/issue when compiling release notes label May 21, 2024
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, simple type check, so I didn't test

@mattkime
Copy link
Contributor Author

/ci

@mattkime mattkime enabled auto-merge (squash) May 23, 2024 16:52
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
dataViews 369 402 +33

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
dataViews 4 3 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dataViews 61.5KB 61.6KB +120.0B
Unknown metric groups

API count

id before after diff
dataViews 1069 1156 +87

References to deprecated APIs

id before after diff
@kbn/lens-embeddable-utils 0 1 +1
@kbn/ml-data-view-utils 0 1 +1
@kbn/search-errors 0 1 +1
@kbn/unified-field-list 0 3 +3
canvas 85 94 +9
controls 19 22 +3
data 17 29 +12
dataViewManagement 40 45 +5
dataVisualizer 8 9 +1
enterpriseSearch 14 17 +3
eventAnnotationListing 0 2 +2
exploratoryView 3 15 +12
fleet 55 56 +1
graph 61 65 +4
infra 2 10 +8
inputControlVis 7 10 +3
lens 80 82 +2
logsShared 1 2 +1
maps 25 26 +1
ml 17 37 +20
presentationUtil 2 3 +1
savedObjectsManagement 8 10 +2
securitySolution 521 525 +4
stackAlerts 17 20 +3
timelines 0 1 +1
transform 4 7 +3
triggersActionsUi 26 27 +1
unifiedSearch 10 13 +3
upgradeAssistant 5 6 +1
uptime 1 3 +2
ux 0 1 +1
visDefaultEditor 0 3 +3
visTypeTimelion 0 2 +2
visTypeTimeseries 12 24 +12
visTypeVega 0 1 +1
total +133

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mattkime

@mattkime mattkime merged commit 692b228 into elastic:main May 23, 2024
21 checks passed
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels May 23, 2024
rshen91 pushed a commit to rshen91/kibana that referenced this pull request May 30, 2024
…3939)

## Summary

Simply changing the type on `ISearchOptions` to work with DataViewLazy.
Nothing that uses `ISearchOption` uses the field list so these are type
only changes

Part of elastic#183694
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Search Querying infrastructure in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants