Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[embeddable rebuild] Embeddable key concepts documentation #183942

Merged
merged 6 commits into from
May 21, 2024
Merged

[embeddable rebuild] Embeddable key concepts documentation #183942

merged 6 commits into from
May 21, 2024

Conversation

nreese
Copy link
Contributor

@nreese nreese commented May 21, 2024

PR adds a "Key concepts" section for embeddable overview documenation

@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes project:embeddableRebuild v8.15.0 labels May 21, 2024
@nreese nreese requested a review from a team as a code owner May 21, 2024 16:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label May 21, 2024
ThomThomson
ThomThomson approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! Great to get more content in this readme.

src/plugins/embeddable/README.md Outdated Show resolved Hide resolved
src/plugins/embeddable/README.md Outdated Show resolved Hide resolved
src/plugins/embeddable/README.md Outdated Show resolved Hide resolved
src/plugins/embeddable/README.md Outdated Show resolved Hide resolved
nreese and others added 5 commits May 21, 2024 14:14
@nreese @ThomThomson
Update src/plugins/embeddable/README.md
52fb7aa 
Co-authored-by: Devon Thomson <devon.thomson@elastic.co>
@nreese @ThomThomson
Update src/plugins/embeddable/README.md
8f15c48 
Co-authored-by: Devon Thomson <devon.thomson@elastic.co>
@nreese @ThomThomson
Update src/plugins/embeddable/README.md
e2f4b4f 
Co-authored-by: Devon Thomson <devon.thomson@elastic.co>
@nreese @ThomThomson
Update src/plugins/embeddable/README.md
0ced3ee 
Co-authored-by: Devon Thomson <devon.thomson@elastic.co>
@nreese
merge with main
6977832
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit 5a939b0 into elastic:main May 21, 2024
17 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Embedding Embedding content via iFrame project:embeddableRebuild release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nreese @elasticmachine @kibana-ci @ThomThomson @kibanamachine