[UII] Fix Fleet Kibana SOs not loading on _debug page
#183948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jen-huang
added
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
nchaulet
approved these changes
May 21, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @jen-huang |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 21, 2024
## Summary As the title says :) (cherry picked from commit 9e109af)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 21, 2024
…age (#183948) (#183952) # Backport This will backport the following commits from `main` to `8.14`: - [[UII] Fix Fleet Kibana SOs not loading on `_debug` page (#183948)](#183948) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jen Huang","email":"its.jenetic@gmail.com"},"sourceCommit":{"committedDate":"2024-05-21T18:58:04Z","message":"[UII] Fix Fleet Kibana SOs not loading on `_debug` page (#183948)\n\n## Summary\r\n\r\nAs the title says :)","sha":"9e109aff36e66b7eb3ee07115349180b04188774","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v8.14.0","v8.15.0"],"title":"[UII] Fix Fleet Kibana SOs not loading on `_debug` page","number":183948,"url":"#183948 Fix Fleet Kibana SOs not loading on `_debug` page (#183948)\n\n## Summary\r\n\r\nAs the title says :)","sha":"9e109aff36e66b7eb3ee07115349180b04188774"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#183948 Fix Fleet Kibana SOs not loading on `_debug` page (#183948)\n\n## Summary\r\n\r\nAs the title says :)","sha":"9e109aff36e66b7eb3ee07115349180b04188774"}}]}] BACKPORT--> Co-authored-by: Jen Huang <its.jenetic@gmail.com>
I don't really see this as a product page where we should enforce a lot of conditions. We should hide that section if the page errors out completely on serverless though (haven't tested). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As the title says :)