[Spacetime] Reimplement config Setting classe in java #15679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
0.0% Coverage on New Code
andsel
force-pushed
the
feature/reimplement_config_classes_in_java
branch
2 times, most recently
from
221c355
to
c5e4e28
Compare
…apper around the new one
…the wrapped Java Setting
…ethod to create a copy of the wrapped Java Setting with the deprecated setting name
…wrapped Java Setting class
…om the wrapped Java Setting class
…wrapped Java Setting class
andsel
force-pushed
the
feature/reimplement_config_classes_in_java
branch
from
e688d12
to
560e8c3
Compare
andsel
commented
May 28, 2024
Comment on lines
-835
to
-836
| clone.instance_variable_set(:@name, alias_name) | ||
| clone.instance_variable_set(:@default, nil) |
There was a problem hiding this comment.
Note for reviewer:
nulling the default value is already done by the deprecate method when create the new instance of the Java Setting class.
|
💚 Build Succeeded
History
cc @andsel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
Reimplement the root Ruby Setting class in Java and use it from the Ruby one, wrapping the Java instance.
Why is it important/What is the impact to the user?
Checklist
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs