Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Clarify AI Assistant will spawn ML nodes #3687

Open
wants to merge 2 commits into
base: 8.12
Choose a base branch
from

Conversation

lucabelluccini
Copy link
Contributor

@lucabelluccini lucabelluccini commented Mar 19, 2024

Clarify AI Assistant will spawn ML nodes

To the doc writers:

  • please change wording
  • backport to all versions back to AI Assistant pages got created
  • add an additional paragraph if the use of AI Assistant / Knowledge Base implies ML Nodes will no more be scaled down back to 0

Clarify AI Assistant will spawn ML nodes
@lucabelluccini lucabelluccini requested a review from a team as a code owner March 19, 2024 08:53
Copy link
Contributor

A documentation preview will be available soon:

@dedemorton dedemorton self-requested a review March 19, 2024 16:20
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the docs. Just some minor changes to follow Elastic style and avoid what grammarians call an unclear antecedent.

docs/en/observability/observability-ai-assistant.asciidoc Outdated Show resolved Hide resolved
@dedemorton dedemorton added backport-8.9 Automated backport with mergify backport-8.10 Automated backport with mergify backport-8.11 Automated backport with mergify backport-8.12 Automated backport with mergify backport-8.13 Automated backport with mergify labels Mar 19, 2024
@dedemorton
Copy link
Contributor

@lucabelluccini Do we want to port this change to the serverless docs, too?

Co-authored-by: DeDe Morton <dede.morton@elastic.co>
@lucabelluccini
Copy link
Contributor Author

Hello @dedemorton - thanks for the review.

I think we need some inputs from engineering as:

  • It would be valuable to also mention the fact enabling AI Assistant / KB will not scale down ML nodes (I am not certain)
  • I think in serverless the autoscaling of ML doesn't work in the same way

@dedemorton
Copy link
Contributor

dedemorton commented Mar 19, 2024

@dgieselaar Can you respond to Lucas' comments here so we can finalize these changes? Thanks! (My apologies if I'm pinging the wrong person here. I'm still trying to figure out who knows what on the team.)

@CoenWarmer
Copy link

CoenWarmer commented Mar 21, 2024

Hello @dedemorton - thanks for the review.

I think we need some inputs from engineering as:

  • It would be valuable to also mention the fact enabling AI Assistant / KB will not scale down ML nodes (I am not certain)

I assume you meant to say 'disabling AI Assistant / KB' ? The AI Assistant will not explicitly scale down ML nodes if it is disabled.

  • I think in serverless the autoscaling of ML doesn't work in the same way

I'm unfamiliar with how autoscaling works in ML, but happy to ask around:

https://elastic.slack.com/archives/C2AJLJHMM/p1711029351315459

@dedemorton
Copy link
Contributor

@CoenWarmer Can you help me interpret the response to the question about autoscaling? The response includes a link to a document that "could be out of date" and the code for autoscaling, so I'm still not sure what, if anything, I need to say in the serverless docs.

Comment on lines +39 to +42
====
In {ecloud} or {ece}, if you have Machine Learning autoscaling enabled, Machine Learning nodes will be started when using the knowledge base and AI Assistant. Therefore using these features will incur additional costs.
====

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
====
In {ecloud} or {ece}, if you have Machine Learning autoscaling enabled, Machine Learning nodes will be started when using the knowledge base and AI Assistant. Therefore using these features will incur additional costs.
====
====
In {ecloud} or {ece}, if you have Machine Learning autoscaling enabled, Machine Learning nodes will be started when using the knowledge base and AI Assistant. Therefore using these features will incur additional costs.
Note that disabling the AI Assistant will not result in ML nodes being scaled down.
====

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucabelluccini Is this what you had in mind?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's great @dedemorton
I would love to get confirmation by engineering whether ML nodes will scale down.
ATM, it seems that once ML jobs are stopped or finish, ML nodes can be automatically scaled down.

But AI Assistant is not using ML Jobs but other ML features...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following up here. Did we ever figure out if ML nodes scale down? This comment https://github.com/elastic/support-tech-lead/issues/1392#issuecomment-2030864999 says we do.

@bmorelli25 bmorelli25 added the backport-8.14 Automated backport with mergify label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.9 Automated backport with mergify backport-8.10 Automated backport with mergify backport-8.11 Automated backport with mergify backport-8.12 Automated backport with mergify backport-8.13 Automated backport with mergify backport-8.14 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants