Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix function names in comment #16

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/env.go
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ func setEnvironment(env EnvironmentType) {
environment = env
}

// GenerateHostID generates and sets the unique hostID
// GenerateNewHostIDIfNecessary generates and sets the unique hostID
func GenerateNewHostIDIfNecessary() error {
var err error

Expand Down
2 changes: 1 addition & 1 deletion interpreter/hotspot/hotspot.go
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ func demangleJavaTypeSignature(signature string, sb io.StringWriter) string {
return ""
}

// demangleJavaSignature demangles a JavaTypeSignature
// demangleJavaMethod demangles a JavaTypeSignature
func demangleJavaMethod(klass, method, signature string) string {
var sb strings.Builder

Expand Down
4 changes: 2 additions & 2 deletions interpreter/nodev8/v8.go
Original file line number Diff line number Diff line change
Expand Up @@ -693,7 +693,7 @@ func isSMI(val uint64) bool {
return val&SmiTagMask == SmiTag
}

// decideSMI extracts the integer value from a SMI. Returns zero for bad tag.
// decodeSMI extracts the integer value from a SMI. Returns zero for bad tag.
func decodeSMI(val uint64) uint32 {
if !isSMI(val) {
return 0
Expand Down Expand Up @@ -1295,7 +1295,7 @@ func (i *v8Instance) getCode(taggedPtr libpf.Address, cookie uint32) (*v8Code, e
return i.readCode(taggedPtr, cookie, nil)
}

// getCodeFromJSFunction reads and caches needed V8 Code object data from a JSFunction pointer.
// getCodeFromJSFunc reads and caches needed V8 Code object data from a JSFunction pointer.
func (i *v8Instance) getCodeFromJSFunc(taggedPtr libpf.Address, cookie uint32) (*v8Code, error) {
if code, ok := i.addrToCode.Get(taggedPtr); ok {
if code.cookie == cookie {
Expand Down