New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove File.path #42053
feat: remove File.path #42053
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs: lgtm
Removing a Custom DOM Elements
doc feels so good 🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving on behalf of the Electron Docs Team
Are we purposely not giving this a full deprecation cycle and going straight to yanking it? |
It was quasi-deprecated in #38776, though it didn't get a breaking-changes.md callout. |
Moved the deletion to 32.x |
🪦 Deprecation Checklist🗑️ Previous deprecations being removed in this PR
@electron/wg-releases: Please confirm these deprecation changes conform to our deprecation policies listed in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @nornagon and also thanks @MarshallOfSound for #38776
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API LGTM
Release Notes Persisted
|
Description of Change
It's time.
Checklist
npm test
passesRelease Notes
Notes: Removed nonstandard
File.path
extension from the WebFile
API.