New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: BrowserView autoresizing conversion error #42056
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes so that @nornagon's suggestions get implemented.
4451a1c
to
91d535d
Compare
91d535d
to
ec8e4a5
Compare
Requested changes were addressed and approved by original requester :)
Release Notes Persisted
|
I have automatically backported this PR to "30-x-y", please check out #42137 |
I have automatically backported this PR to "31-x-y", please check out #42138 |
|
Description of Change
Closes #42003.
Fixes the following issue when setting autoResize on a
BrowserView
:This was happening because
setBounds
accepts agfx::Rect
and we were trying to pass double values to the width and height when resizing.Checklist
npm test
passesRelease Notes
Notes: Fixes an error when calling
setAutoResize
on aBrowserView
.