refactor: use raw_ref in RootView #42114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Chromium C++ style guide says "prefer const raw_ref<T> whenever the held pointer will never be null," so let's do that.
> The Chromium C++ style guide says "prefer const raw_ref<T> whenever > the held pointer will never be null," so let's do that.
RootView already owns it, so aggregate it
electron-cation
bot
added
new-pr 馃尡
codebytere
approved these changes
May 15, 2024
jkleinsc
approved these changes
May 15, 2024
|
No Release Notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Make the ownership / nullability contract for
RootViewfields a little stricter:raw_ref<T>instead ofraw_ptr<T>for class fields that can never benullptrViewTrackerdirectly since RootView already owns it, and its lifecycle is identical to the RootView, and the RootView header was already including the ViewTracker headerAll reviews welcomed. CC @nornagon as most recent committer and @miniak for general C++ tidying 馃樃
Checklist
npm testpassesRelease Notes
Notes: none.