fix: partially revert invalidate focus ring #42126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VerteDinde
added
semver/patch
dsanders11
approved these changes
May 11, 2024
1 task
3 tasks
ckerr
approved these changes
May 13, 2024
There was a problem hiding this comment.
tldr: 👍 to everything @VerteDinde said in the description.
- I've confirmed this fixes the issue for me in local builds
- This is a reasonable way to unblock releases while we figure out the root cause
- Once we track down the root cause, it would be preferable to fix that and drop this patch if possible
|
Release Notes Persisted
|
This was referenced May 13, 2024
|
I have automatically backported this PR to "30-x-y", please check out #42145 |
trop
bot
added
in-flight/30-x-y
and removed
target/30-x-y
|
I have automatically backported this PR to "31-x-y", please check out #42146 |
trop
bot
added
in-flight/31-x-y
merged/30-x-y
jkleinsc
added a commit
that referenced
this pull request
May 13, 2024
3 tasks
5 tasks
VerteDinde
pushed a commit
that referenced
this pull request
May 13, 2024
VerteDinde
added a commit
that referenced
this pull request
May 13, 2024
chore: update patches after focus ring was merged
Mrnikifabio
pushed a commit
to Mrnikifabio/electron
that referenced
this pull request
May 14, 2024
Mrnikifabio
pushed a commit
to Mrnikifabio/electron
that referenced
this pull request
May 14, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #41839
We were seeing an inconsistent segfault on Ubuntu and several other Linux distros, and traced it back to this CL:https://chromium-review.googlesource.com/c/chromium/src/+/5344356. It appeats that the current upstream layout invalidation logic doesn't always invalidate a parent and child correctly. A label's bounds could change without being invalidated because its container can change its bounds.
We should handle this layout logic to better handle parent/child invalidation (see #41899, which is in progress) and upstream a fix if possible, but this PR should unblock developers wanting to upgrade to E31 and E30.
cc @ckerr @Kilian
Checklist
npm testpassesRelease Notes
Notes: Fixed an inconsistent crash on maximizing window and relayout in Ubuntu.