Fix formatting and add convert_to_lower flag to elementary.generate_schema_baseline_test #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-for-generate-schema-baseline-test-macro
…hema-baseline-test-macro
dapollak
reviewed
Jan 4, 2024
| {%- for column in columns %} | ||
| - name: {{ column.name }} | ||
| {%- if convert_to_lower %} | ||
| data_type: {{ column.dtype|lower }} |
dapollak
reviewed
Jan 4, 2024
| - name: {{ node.name }} | ||
| columns: | ||
| {%- for column in columns %} | ||
| - name: {{ column.name }} | ||
| {%- if convert_to_lower %} | ||
| data_type: {{ elementary.get_column_data_type(column) | lower }} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request addresses the issue #810 where the output of
elementary.generate_schema_baseline_testhas incorrect indentation. It also introduces theconvert_to_lowerflag to control the case of data types in the output.Changes:
Refactor the
generate_schema_baseline_testmacro to separate the YAML generation for models and sources into two separate macros.Introduce the
convert_to_lowerflag as a parameter to theelementary.generate_schema_baseline_testoperation. When set toTrue, the output will default to lowercase for data types.With these modifications, the output will be correctly formatted, and users can now control the case of the output using the
convert_to_lowerflag.