WIP - Clickhouse integration #507
Conversation
Clickhouse integration dev
|
Hello, do you need any help, I'd be happy to contribute |
Hey, would love to receive any help that you could provide! Please check out this guideline provided by Maayan. As of now, we have completed step 1. Now we need to focus on adding support in the CLI for Slack alerts and UI generation |
There was a problem hiding this comment.
Great contribution @Arun-kc
I see its still a WIP, but i still added some notes (mainly conventions), so take a look when you got the time 😄
| {% endmacro %} | ||
|
|
||
| {% macro clickhouse__edr_current_timestamp_in_utc() %} | ||
| toDateTime(toUInt32(toUnixTimestamp(now()) - 7 * 86400)) |
There was a problem hiding this comment.
Can you explain a bit about these numbers? how does it make it into UTC?
| _parameter("user", target.user), | ||
| _parameter("password", "<PASSWORD>"), | ||
| _parameter("schema", elementary_schema), | ||
| _parameter("driver", "<http|native>"), |
There was a problem hiding this comment.
is this available through the target (e.g target.driver)? if so i believe it would be better
| @@ -27,7 +27,11 @@ time_window_aggregation as ( | |||
| bucket_duration_hours, | |||
| updated_at, | |||
| avg(metric_value) over (partition by metric_name, full_table_name, column_name order by bucket_start asc rows between unbounded preceding and current row) as training_avg, | |||
| {% if target.type == 'clickhouse' %} | |||
There was a problem hiding this comment.
We prefer to have the adapter specific code use adapter.dispatch and contained in the cross_db_utils section of the code, if you could add there an edr_stddev macro it would be awesome
[ELE-33] [Feature] Support Clickhouse #52