Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ELE-1628 - Move dbt deps to docker building-time rather than run-time #1296

Closed
wants to merge 0 commits into from
Closed

ELE-1628 - Move dbt deps to docker building-time rather than run-time #1296

wants to merge 0 commits into from

Conversation

yimingpeng
Copy link

Overview

This PR aims to resolve #1110 which moves the installation of dbt dependencies into the Docker build process. The PR includes:

  • A bash script (install_dbt_deps.sh) to define related env variables and run dbt deps.
  • Changes to the Dockerfile to execute this script during the build.

Run & Test

  1. docker build -f ./Dockerfile -t elementary-data --no-cache .
image
  1. docker run elementary-data
Screenshot 2023-11-26 at 5 19 33 PM
  1. pre-commit passed
Screenshot 2023-11-26 at 5 20 36 PM

@yimingpeng yimingpeng mentioned this pull request Nov 26, 2023
Open
@yimingpeng yimingpeng closed this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ELE-1628] Call dbt deps on Dockerfile instead of running it on the edr run.
1 participant
@yimingpeng