Chunk calls to DBT based on string length #1354
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On occasion 100 sources will result in an argument length that is too long, instead chunk using the serialised json string representation of the argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1353
Bug
In some scenarios the argument list Elementary calls DBT with when uploading source freshness exceeds the limit of the operating system.
This is because the chunking of calls to DBT is currently based on the number of sources and not the length of the arguments. So some combination of sources results in longer argument lists than others.
This PR changes the chunking to use the character length and adds a buffer to allow for a bit of variation.
Testing
I've tested this locally by patching elementary in our deployment and confirming the results are uploaded.