Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen the version constrain of the click package #1489

Merged
merged 2 commits into from May 21, 2024

Conversation

yu-iskw
Copy link
Contributor

@yu-iskw yu-iskw commented Apr 12, 2024

Motivation

I got the error message to install elementary in addition to dbt-core. I assume that is caused by the difference of the version constrains of the click package in dbt-core and elememtary. I would expect pip appropriately handle the version constrains in both of dbt-core and elementary. But, sometimes it doesn't work. In my opinion, we are probably loosen the version constrains so that we can also catch up with new releases of click. The latest version is today 8.1.7.

  • pip: 23.3.2
  • dbt-core: 1.7.11
$ pip install 'elementary-data[bigquery]'
...
elementary-data 0.14.0 requires click<8.1.4,>=7.0, but you'll have click 8.1.7 which is incompatible.

https://github.com/dbt-labs/dbt-core/blob/c86cec3256cfeb636d47f21279f3cb689d585439/core/setup.py#L62

Signed-off-by: Yu Ishikawa <yu-iskw@users.noreply.github.com>
@yu-iskw yu-iskw marked this pull request as ready for review April 12, 2024 03:45
@yu-iskw
Copy link
Contributor Author

yu-iskw commented May 20, 2024

@oravi Sorry for bothering you. What are your thoughts on the change?

@mi-volodin
Copy link

Upvoting this one.
Elementary-data now in direct conflict with Airflow 2.7.2 constraints where click has == 8.1.7 version.

List of changes for the click since 8.1.4, seems only issue fixes and no breaking changes.

@mi-volodin
Copy link

@haritamar Can you take a look at this? I saw you closed a pydantic issue, which is similar (I wonder how it wasn't mentioned in the same issue).

@haritamar
Copy link
Collaborator

Hi @mi-volodin and @yu-iskw !
Sorry for the delay here.
The limitation was meant to be temporary due to an issue in v8.1.4 specifically - but we can totally loosen it now.

@haritamar haritamar merged commit 0fc9b11 into elementary-data:master May 21, 2024
1 of 3 checks passed
@mi-volodin
Copy link

@haritamar thanks a lot! A great relief for the team.
@yu-iskw thanks for making a PR 🙏

@yu-iskw
Copy link
Contributor Author

yu-iskw commented May 22, 2024

@haritamar Thank you for merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants