Fix: Remove styling 'all: unset' from buttons which caused focus problems in Firefox [ED-14521] #27336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hein-obox
commented
May 15, 2024
| @@ -251,11 +251,4 @@ | |||
| border-radius: $border-radius; | |||
| } | |||
| } | |||
|
|
|||
| @mixin button-focus-outline() { | |||
hein-obox
commented
May 15, 2024
| @@ -179,8 +180,6 @@ | |||
| gap: var(--n-tabs-icon-gap); | |||
| border-width: var(--n-tabs-border-width); | |||
| position: relative; | |||
| cursor: pointer; | |||
There was a problem hiding this comment.
The button has a pointer by default, but was overridden by the all: unset styling.
hein-obox
commented
May 15, 2024
| @@ -203,8 +202,6 @@ | |||
| -webkit-text-stroke-color var(--n-tabs-title-transition ), | |||
| transform var(--n-tabs-title-transition); | |||
|
|
|||
| @include button-focus-outline; | |||
There was a problem hiding this comment.
We prefer to use the default styling inside, which was overridden by the all: unset styling.
…om-buttons-which-caused-focus-problems-in-firefox
…om-buttons-which-caused-focus-problems-in-firefox
…which-caused-focus-problems-in-firefox' of https://github.com/marcelementor/elementor into fix/ED-14521-fix-remove-styling-all-unset-from-buttons-which-caused-focus-problems-in-firefox
…om-buttons-which-caused-focus-problems-in-firefox
…om-buttons-which-caused-focus-problems-in-firefox
…om-buttons-which-caused-focus-problems-in-firefox
…om-buttons-which-caused-focus-problems-in-firefox
rami-elementor
approved these changes
May 23, 2024
…om-buttons-which-caused-focus-problems-in-firefox
…om-buttons-which-caused-focus-problems-in-firefox
…om-buttons-which-caused-focus-problems-in-firefox
…om-buttons-which-caused-focus-problems-in-firefox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What kind of change does this PR introduce?
Summary
This PR can be summarized in the following changelog entry:
Description
An explanation of what is done in this PR
Test instructions
This PR can be tested by following these steps:
Quality assurance
Fixes #