Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: Conversion Center - Link in Bio v7 -Adjust icons layout model #27357

Merged

Conversation

willhowat
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Summary

This PR can be summarized in the following changelog entry:

  • Link in bio - Variation 7 - icons maintain initial content width

Description

An explanation of what is done in this PR

  • Adjusted flex model of icons to ensure they do not stretch out when content width is increased

Test instructions

This PR can be tested by following these steps:

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended
  • Docs have been added / updated (for bug fixes / features)

Fixes #

@willhowat willhowat requested a review from louiswol94 May 17, 2024 08:10
ronenelementor
ronenelementor previously approved these changes May 20, 2024
davseve
davseve previously approved these changes May 20, 2024
louiswol94
louiswol94 previously approved these changes May 20, 2024
@willhowat willhowat requested a review from louiswol94 May 21, 2024 08:49
@louiswol94 louiswol94 merged commit 06d6976 into elementor:main May 21, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants