Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusts the creation of the query string. #84

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Adjusts the creation of the query string. #84

merged 3 commits into from
Apr 23, 2024

Conversation

mrctrifork
Copy link

This pull requests closes #83 and closes #82 .

  • It adjusts the string concatenation to ensure query keys and values are URL encoded so they don't produce invalid URLs
  • It also takes in account that the value of the query: Record can be an array of values, and properly serializes them

@SaltyAom SaltyAom merged commit 53d030c into elysiajs:main Apr 23, 2024
1 check passed
@SaltyAom SaltyAom mentioned this pull request Apr 23, 2024
Closed
@MatthewAry
Copy link
Contributor

Consider: elysiajs/elysia#604

@SaltyAom
Copy link
Member

Consider: elysiajs/elysia#604

Assuming you are trying to type query as Record<string, string | string[]>, this PR has also added the same type as your PR.

Let me know if I'm missing something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaltyAom SaltyAom SaltyAom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@mrctrifork @MatthewAry @SaltyAom @NanoSpicer