Add go-to definition in metadata #4441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
client
|
@razzmatazz WDYT? 🤔 |
razzmatazz
approved these changes
May 13, 2024
Reviewed, thank you! Approved 👍🏻 , with a suggestion to rename omnisharp-related fns to have |
|
@cheerio-pixel Friendly ping! :) |
Now if we try to find the definition of a symbol that is defined externally, it will try to load a stripped-down version of the file where is defined and show it in a temporal file.
Sorry, completly forgot everything about this. Thanks for the ping. |
I renamed functionallity only used by omnisharp to be prefixed with lsp-csharp--omnisharp- I'm a little bit torn with lsp-csharp--path->qualified-name being prefixed like that, but only omnisharp is using it.
cheerio-pixel
force-pushed
the
feature-add-goto-metadata
branch
from
46888fb
to
25f88b1
Compare
|
@jcs090218 Finished applying the suggestions. Sorry for messing up with the historial. I didn't realize that rebase modifies the authoring information. |
|
Can you fix these compile warnings? Thanks! :) |
jcs090218
reviewed
May 29, 2024
|
@jcs090218 Anything more? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviving the work of razzmat, I have reworked his pull request to support this feature.