-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add Excel Loader to load .xlsx #1145
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great. Left a minor comment.
Thanks for the contrbution. ❤️ 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left few comments. Thanks for adding this btw! ❤️
LGTM! @eren-darici Could you please resolve the conflicts? Also, it would be great it you can add docs for this here. |
@@ -148,6 +148,8 @@ google-auth-oauthlib = { version = "^1.2.0", optional = true } | |||
google-auth = { version = "^2.25.2", optional = true } | |||
google-auth-httplib2 = { version = "^0.2.0", optional = true } | |||
google-api-core = { version = "^2.15.0", optional = true } | |||
pandas = {version = "^2.1.4", optional = true} | |||
openpyxl = {version = "^3.1.2", optional = true} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need this dependency? I don't see it getting used anywhere though.
Description
How Has This Been Tested?
Checklist:
Maintainer Checklist