⚡️ Speed up _format_message()
by 81% in embedchain/store/assistants.py
#1261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
📄
_format_message()
inembedchain/store/assistants.py
📈 Performance went up by
81%
(0.81x
faster)⏱️ Runtime went down from
47.00μs
to25.90μs
Explanation and details
(click to show)
The given code mostly consists of class and method definitions, so there's limited room for optimization because the computational complexity is relatively low. However, there are minor changes that can be applied for a bit of efficiency:
Using
is not None
comparisons in place ofor
checks in the constructor could prevent potential issues with zero values (0
,''
,False
, etc.), which areFalse
in a boolean context.Used
c.__class__ is MessageContentText
instead ofisinstance(c, MessageContentText)
. This checks for the exact type, not subclasses, which is faster if no subclassing is being used.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
The new optimized code was tested for correctness. The results are listed below.
✅ 10 Passed − 🌀 Generated Regression Tests
(click to show generated tests)
Checklist:
Maintainer Checklist