Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifai : Added Clarifai as LLM and embedding model provider. #1311

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

mogith-pn
Copy link

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Please delete options that are not relevant.

  • Unit Test
  • Test Script (please provide)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

* added clarifai LLM and embedders

* added clarifai config  files

* Added clarifai example docs

* Update clarifai llms.mdx

* Added try/except blocks in model predict

* Modified markdown example files
Copy link
Collaborator

@deshraj deshraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thanks for adding this @mogith-pn

docs/components/embedding-models.mdx Outdated Show resolved Hide resolved
docs/components/llms.mdx Outdated Show resolved Hide resolved
embedchain/embedder/clarifai.py Outdated Show resolved Hide resolved
embedchain/llm/clarifai.py Outdated Show resolved Hide resolved
configs/clarifai.yaml Outdated Show resolved Hide resolved
@deshraj
Copy link
Collaborator

deshraj commented Mar 12, 2024

@mogith-pn can you please run poetry lock --no-update so that the poetry.lock file is updated? Seems like the CI is failing because of this.

@mogith-pn
Copy link
Author

@deshraj
Thanks for the quick review. I have executed poetry lock --no-update and committed the changes.
Please take a look into it.

@mogith-pn mogith-pn requested a review from deshraj March 13, 2024 12:03
@mogith-pn
Copy link
Author

@deshraj ,
Addressed linting issues, could you please re-run the workflows.
TIA :)

@mogith-pn
Copy link
Author

@deshraj ,
I have adjusted the test code, meanwhile I couldn't able to run the tests locally, I'm getting the following error
RuntimeError: Session factory is not initialized. Call setup_engine() first. error.

@deshraj
Copy link
Collaborator

deshraj commented Mar 20, 2024

@mogith-pn can you try to run rm -rf ~/.embedchain and try running tests again? It should work then

@mogith-pn
Copy link
Author

@mogith-pn can you try to run rm -rf ~/.embedchain and try running tests again? It should work then

Thanks @deshraj !
Please take a loot at it now. I have fixed the errors.

@deshraj
Copy link
Collaborator

deshraj commented Mar 21, 2024

Seems like there are some lint issues. Can you please fix it by running make lint format

@mogith-pn
Copy link
Author

@deshraj
Apologies !
Addressed the lint issues.

@deshraj
Copy link
Collaborator

deshraj commented Mar 22, 2024

Still seeing the issue:

embedchain/vectordb/qdrant.py:3:8: F401 [*] `uuid` imported but unused

Can you please remove the UUID import? Thanks!

@mogith-pn
Copy link
Author

@deshraj
Is it really needed, because when i ran poetry run ruff . I'm getting all checks passed as result. And I also noticed there's an existing PR which addresses this ?

@deshraj
Copy link
Collaborator

deshraj commented Mar 26, 2024

Yeah, can you please fix it in your PR? We won't be able to merge the PR unless the CI checks pass.

@mogith-pn
Copy link
Author

Yeah, can you please fix it in your PR? We won't be able to merge the PR unless the CI checks pass.

Hi @deshraj ,
The issue is fixed, could you please re-run the CI.
TIA :)

@mogith-pn
Copy link
Author

Yeah, can you please fix it in your PR? We won't be able to merge the PR unless the CI checks pass.

Hi @deshraj , The issue is fixed, could you please re-run the CI. TIA :)

Hey @deshraj ,
Hope you are doing well. Could you please initiate re-run for the tests. TIA :)

@mogith-pn
Copy link
Author

Hi @deshraj / @taranjeet ,
Could you please re-initiate the workflow ?
Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants