Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mssqlserver] Add all SP cycles #3992

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

[mssqlserver] Add all SP cycles #3992

wants to merge 25 commits into from

Conversation

@BiNZGi BiNZGi added the release-updates Pull Requests that update release information label Oct 31, 2023
@BiNZGi BiNZGi marked this pull request as ready for review October 31, 2023 07:35
@marcwrobel
Copy link
Member

Given original releases and SP support periods overlap, shouldn't we document those in separate entries ?

@BiNZGi
Copy link
Member Author

BiNZGi commented Nov 2, 2023

Given original releases and SP support periods overlap, shouldn't we document those in separate entries ?

Fully agree, will do that and update this PR.

@BiNZGi BiNZGi self-assigned this Nov 2, 2023
@BiNZGi BiNZGi marked this pull request as draft November 8, 2023 17:12
@BiNZGi BiNZGi changed the title [mssqlserver] Update releaseDate to RTM date [mssqlserver] Add all SP cycles Nov 10, 2023
products/mssqlserver.md Outdated Show resolved Hide resolved
@BiNZGi BiNZGi marked this pull request as ready for review November 13, 2023 08:21
@BiNZGi BiNZGi removed their assignment Nov 13, 2023
@BiNZGi
Copy link
Member Author

BiNZGi commented Nov 20, 2023

@endoflife-date/everyone glad if someone could take the time to review 🥇

Copy link
Member

@marcwrobel marcwrobel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not check the dates yet, but here are my first thoughts.

products/mssqlserver.md Outdated Show resolved Hide resolved
products/mssqlserver.md Outdated Show resolved Hide resolved
products/mssqlserver.md Outdated Show resolved Hide resolved
products/mssqlserver.md Show resolved Hide resolved
Copy link
Member

@marcwrobel marcwrobel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed up to 2017 (Helsinki) so far. Here are my first comments.

products/mssqlserver.md Outdated Show resolved Hide resolved
products/mssqlserver.md Outdated Show resolved Hide resolved
Copy link
Member

@marcwrobel marcwrobel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed until - 2016 (SQL16), here are a few more comments.

codename: Hekaton
releaseLabel: "2014 SP2"
releaseDate: 2016-07-14
support: 2020-01-14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Careful, on https://learn.microsoft.com/en-us/lifecycle/products/sql-server-2014 see Section "Releases", Entry "Service Pack 2" -> Column "End Date" -> Jan 14, 2020

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the support date was using either the Mainstream End Date, or the Release End Date if it was earlier. If I understand correctly this is only true for the latest service pack (a few SP3 are in this case) ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And in this case is it correct to consider that the Extended Security Updates will be applied to the last service pack ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the "End Date" for the releaseCycle (with the SP applied).

And in this case is it correct to consider that the Extended Security Updates will be applied to the last service pack ?

Yes, that is correct.

products/mssqlserver.md Show resolved Hide resolved
products/mssqlserver.md Outdated Show resolved Hide resolved
codename: Hekaton
releaseLabel: "2014 SP2"
releaseDate: 2016-07-14
support: 2020-01-14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And in this case is it correct to consider that the Extended Security Updates will be applied to the last service pack ?

@usta
Copy link
Member

usta commented May 18, 2024

@BiNZGi what is the lastest situation about this PR ? could you fix conflicts so we can merge ?

@BiNZGi
Copy link
Member Author

BiNZGi commented May 21, 2024

what is the lastest situation about this PR ?

From my side this PR is actual and in merge-able state. I think @marcwrobel is still in the review process...

could you fix conflicts so we can merge ?

fixed

@usta
Copy link
Member

usta commented May 21, 2024

@marcwrobel waiting for your merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-updates Pull Requests that update release information
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants