Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[office] Add 2019 for Mac, 2016 for Mac, 2004 for Mac, 2003, XP, Update releaseDate to RTM date #3993

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

BiNZGi
Copy link
Member

@BiNZGi BiNZGi commented Oct 31, 2023

See release links for RTM date
Relates to #3960

@BiNZGi BiNZGi added the release-updates Pull Requests that update release information label Oct 31, 2023
@BiNZGi BiNZGi changed the title [office] Add 2019 for Mac, 2016 for Mac, Update releaseDate to RTM date [office] Add 2019 for Mac, 2016 for Mac, 2004 for Mac, 2003, XP, Update releaseDate to RTM date Oct 31, 2023
@BiNZGi BiNZGi marked this pull request as ready for review October 31, 2023 08:15
@@ -38,39 +52,60 @@ releases:

- releaseCycle: "2013"
releaseLabel: "2013 SP1"
releaseDate: 2014-02-25
releaseDate: 2013-01-09
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given support period overlap for 2013 and 2013 SP1 release, shouldn't we document those in separate entries ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since both releases are EOL, it should be okay to collapse it into a single row.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback. MS sees these service packs as separate cycles:

Original Release -> Start: Jan 9, 2013, End: Apr 14, 2015
Service Pack -> Start: 1 Feb 25, 2014, End: Apr 11, 2023

We should add them also as additional cycles as we have it like in Windows with 23H2, etc. Will do that and update this PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since both releases are EOL, it should be okay to collapse it into a single row.

This may not be very practical for API users because of the lack of consistency. I think we should either document major versions, or minor versions, but not mix both.

@BiNZGi BiNZGi self-assigned this Nov 2, 2023
@BiNZGi BiNZGi marked this pull request as draft November 8, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-updates Pull Requests that update release information
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants