Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new product] chef-infra-client #4388

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

nperez60
Copy link
Contributor

add new product chef-client

@marcwrobel marcwrobel added the new-product This PR adds a new product to the website. label Dec 29, 2023
@nperez60 nperez60 marked this pull request as ready for review January 4, 2024 19:34
@nperez60
Copy link
Contributor Author

nperez60 commented Jan 4, 2024

Seems good to me

@tas50
Copy link
Contributor

tas50 commented Jan 5, 2024

Glad to see someone adding this project. As a past Chef developer and later the PM for the client I would call out that the project name hasn't been Chef Client for a number of years. This should be updated to be Chef Infra Client, which is the name of the project currently. Other than that it looks great.

@nperez60 nperez60 changed the title [new product] chef-client.md [new product] chef-infra-client.md Jan 5, 2024
replace Chef Client to Chef Infra Client
@nperez60
Copy link
Contributor Author

nperez60 commented Jan 5, 2024

@tas50 thanks for your feedback, I updated the PR

@nperez60 nperez60 changed the title [new product] chef-infra-client.md [new product] chef-infra-client Jan 9, 2024
products/chef-client.md Outdated Show resolved Hide resolved
products/chef-client.md Outdated Show resolved Hide resolved
@nperez60 nperez60 marked this pull request as draft January 13, 2024 15:43
@marcwrobel
Copy link
Member

Still draft or ready for review ?

@nperez60
Copy link
Contributor Author

@marcwrobel, I am waiting to have some time to work on #4425
I will put this PR in ready for review when I find a solution for the other one

@tas50
Copy link
Contributor

tas50 commented Mar 10, 2024

There's a lot of release dates here that still need to get updated. I think some of this is confusion on how Chef's version numbers work. When I used to do these releases we would cutover master/main to the new version sometime in January to start prepping things for our yearly April release. The first commit afer this bump will become say 17.0.0 and every release after this continues to bump the minor version. This was done as each commit builds a package that users can download from the current build repo. When we were happy with things and wanted to do the release we'd just tag a build "stable" and ship it. That means for something like 16.0 the first released version is actually 16.0.275 in May when the 16.0.0 tag is all the way back in Jan. TLDR: Don't trust the github tags.

@nperez60
Copy link
Contributor Author

@tas50 thanks for the feedback / sources
@marcwrobel do I need to update each release manually or we agree that the script in endoflife-date/release-data#328 will update each release if needed ?

@nperez60
Copy link
Contributor Author

Hi, let me know if any modifications are needed

@usta
Copy link
Member

usta commented May 18, 2024

@marcwrobel is everthing ok for this PR ? is it ready to land or not ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-product This PR adds a new product to the website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants