[new product] wireshark #4440
[new product] wireshark #4440
Conversation
|
LGTM |
products/wireshark.md
Outdated
| # https://regex101.com/r/fHvpY1/1 | ||
| regex: ^wireshark-(?<major>\d+)\.?(?<minor>\d*[02468])\.?(?<patch>\d+)?\.?(?<tiny>\d+)?$ |
There was a problem hiding this comment.
This is missing some tags: that do not use the wireshark- prefix. See v1.10.1, and the 1.11 releases.
There was a problem hiding this comment.
On my side, 1.10.1 is matched by the regex :
wireshark-1.10.1
1.11 release is an odd release number, actualy this PR only tracks even numbers releases, odd numbers releases are not supported as they are developpement release
The Minor release number basically follows an even/odd number scheme. For every official release an even number is assigned and the code is branched off for maintenance. The development continues on the next higher odd release number. Note that this development package is a moving target and meaningless without its commit ID.
Should I add odd releases in the PR ?
Co-authored-by: Nemo <me@captnemo.in>
Co-authored-by: Nemo <me@captnemo.in>
|
Hi, let me know if any modifications are needed |
add wireshark product
close #3669