Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[emberjs] Adds 5.8 #5021

Merged
merged 3 commits into from May 20, 2024
Merged

[emberjs] Adds 5.8 #5021

merged 3 commits into from May 20, 2024

Conversation

captn3m0
Copy link
Member

Release Announcement: https://blog.emberjs.com/ember-released-5-8/

Dated: 20 Apr 2024

@captn3m0
[emberjs] Adds 5.8
690f4f4 
Release Announcement: https://blog.emberjs.com/ember-released-5-8/

Dated: 20 Apr 2024
@captn3m0 captn3m0 added the release-updates Pull Requests that update release information label Apr 22, 2024
@captn3m0 captn3m0 requested a review from BiNZGi April 22, 2024 16:14
@captn3m0 captn3m0 self-assigned this Apr 22, 2024
@captn3m0 captn3m0 mentioned this pull request Apr 22, 2024
Merged
BiNZGi
BiNZGi requested changes Apr 23, 2024
View reviewed changes
Copy link
Member

@BiNZGi BiNZGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@captn3m0 please check comments

products/emberjs.md Outdated Show resolved Hide resolved
products/emberjs.md Outdated Show resolved Hide resolved
@captn3m0 captn3m0 mentioned this pull request Apr 24, 2024
Open
@marcwrobel marcwrobel mentioned this pull request Apr 27, 2024
Merged
@captn3m0 captn3m0 mentioned this pull request May 1, 2024
Merged
BiNZGi
BiNZGi approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@BiNZGi BiNZGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I leave it up to you if you want to wait any longer for the linked issue. From my view, you can merge the current update.

This was referenced May 13, 2024
Merged
Merged
@usta
Copy link
Member

usta commented May 18, 2024

@captn3m0 this have been waiting more than 3 weeks

@marcwrobel @BiNZGi
Update products/emberjs.md
05e539d 
Co-authored-by: BiNZGi <BiNZGi@users.noreply.github.com>
marcwrobel
marcwrobel reviewed May 20, 2024
View reviewed changes
Copy link
Member

@marcwrobel marcwrobel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reply on ember-learn/ember-website#1103, will merge.

@marcwrobel marcwrobel merged commit 14dd4d8 into master May 20, 2024
5 checks passed
@marcwrobel marcwrobel deleted the ember-5.8 branch May 20, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcwrobel marcwrobel marcwrobel approved these changes

@BiNZGi BiNZGi BiNZGi approved these changes

Assignees

@captn3m0 captn3m0

Labels
release-updates Pull Requests that update release information
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@captn3m0 @usta @marcwrobel @BiNZGi