Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new product] pnpm #5062

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[new product] pnpm #5062

wants to merge 5 commits into from

Conversation

Signed-off-by: Rui Chen <rui@chenrui.dev>

[pnpm] add security policy support link

Signed-off-by: Rui Chen <rui@chenrui.dev>
@captn3m0
Copy link
Member

captn3m0 commented May 1, 2024

Dates for older releases seem easily available, lets them as well:

@chenrui333
Copy link
Member Author

nice finding. adding them

Signed-off-by: Rui Chen <rui@chenrui.dev>
products/pnpm.md Outdated Show resolved Hide resolved
---
title: Pnpm
category: app
tags: package-manager javascript-runtime
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tags: package-manager javascript-runtime
tags: build-tool javascript-runtime

See #4263 (comment).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is not true. I am happy to remove it and add package-manager later, but I dont think adding build-tool is right move.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package-manager not being an existing tag, it will have to be added in a separate PR (see documentation on https://endoflife.date/contribute). So you can file a separate issue for that if you want.

products/pnpm.md Outdated Show resolved Hide resolved
products/pnpm.md Outdated Show resolved Hide resolved
releaseDate: 2019-10-07
eol: 2021-04-24
latest: '4.14.4'
latestReleaseDate: 2020-05-22
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
latestReleaseDate: 2020-05-22
latestReleaseDate: 2020-05-23

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what date are we using? EST or UTC or CET?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tend to use UTC, as most of our script use this (except git which use the repo's timezone, at least for now).

Anyway this suggestion is based on the scripts in https://github.com/endoflife-date/release-data/.

---

> [Pnpm](https://pnpm.io/) is a fast, disk space efficient package manager for JavaScript.
> It is a drop-in replacement for npm, but faster and more efficient.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a little paragraph explaining the support policy ? From what I could see with the comment of @captn3m0 they support the last two releases ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upstream did not explicitly see that, but I guess we can assume it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comment was a question, not an affirmation. It's also OK to just write that dates are only documented on https://github.com/pnpm/pnpm/security/policy (but in this case it is redundant with the sentence added with the releasePolicyLink, so I suggest to remove the releasePolicyLink in favor of a more explicit sentence).

chenrui333 and others added 3 commits May 3, 2024 17:31
Co-authored-by: Marc Wrobel <marc.wrobel@gmail.com>
Co-authored-by: Marc Wrobel <marc.wrobel@gmail.com>
Co-authored-by: Marc Wrobel <marc.wrobel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants