Automatically generate un-hyphenated variants of permalinks #5099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcwrobel
requested changes
May 10, 2024
There was a problem hiding this comment.
Seems _site/_redirects is completely messed up with this change: there are a lot of redirects added for unrelated product, such as:
diff --git i/toto w/toto
index ba376eaf..ff46302b 100644
--- i/toto
+++ w/toto
@@ -5,52 +5,1773 @@
# Redirects for _redirects
# Redirects for products/akeneo-pim.md
+/vuetify /akeneo-pim
+/lua /akeneo-pim
+/apiplatform /akeneo-pim
+/splunk /akeneo-pim
+/coldfusion /akeneo-pim
+/opensearch /akeneo-pim
+/contao /akeneo-pim
+/filemaker /akeneo-pim
+/iphone /akeneo-pim
+/istio /akeneo-pim
+/surface /akeneo-pim
+/tomcat /akeneo-pim
+/terraform /akeneo-pim
+/grafana /akeneo-pim
+/watchos /akeneo-pim
+/artifactory /akeneo-pim
+/nvidia /akeneo-pim
+/amazoncdk /akeneo-pim
+/nuxt /akeneo-pim
+/consul /akeneo-pim
+/php /akeneo-pimI don't know why, could you confirm ?
| unhyphenated_permalink = permalink.delete('-') | ||
| alternate_urls = page.data['alternate_urls'] || [] | ||
| unless alternate_urls.include?(unhyphenated_permalink) | ||
| alternate_urls << unhyphenated_permalink |
There was a problem hiding this comment.
This adds permalink without hyphen to the alternate_urls list, which is not the expected behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2426
For more details, open the Copilot Workspace session.