Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dashboard to design v122 (Part 1) #9896

Open
wants to merge 68 commits into
base: develop
Choose a base branch
from

Conversation

somebody1234
Copy link
Collaborator

Pull Request Description

  • Close Update the Dashboard to Newest Design #9886

    • Update style of buttons in Drive Bar
    • Move "Home" page into a "Start" dialog
    • Remove icons that are no longer needed
    • Remove Backend Switcher in top bar - they have now been converted to categories
  • Incidental changes

    • Refactor Backend provider so that both Remote and Local backends are available.
      • This was done because both Cloud and Local backends are now easily accessible by switching tabs - the Local backend no longer has its own views with the hidden category switcher

Important Notes

None

Code review tips

  • There are a lot of changes in Settings components, for example (and in general, any component that needs to use a backend). However, most of the changes are identical, so only the approach needs to be reviewed - although the settings pages and the other pages should probably be reviewed separately.

Testing instructions

  • Make sure new/changed features work, as mentioned above (drive bar, start page, drag-n-drop)
  • Because of the backend changes, all flows in general should be checked, at least at a basic level:
    • Sign up/sign in
    • Offline mode (bottom link on login screen on desktop app)
    • Checking that all settings pages work, both when logged in and not logged in

Screencasts

dashboard-122.mp4

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@somebody1234 somebody1234 added CI: No changelog needed Do not require a changelog entry for this PR. x-new-feature Type: new feature request g-dashboard labels May 9, 2024
@somebody1234
Copy link
Collaborator Author

I guess I'll avoid stacking the move to tabs on top of this PR, as this is a big PR so there may be a lot of changes needed.

@somebody1234
Copy link
Collaborator Author

on second thought 1 will be left for later

@PabloBuchu
Copy link
Contributor

  1. After clicking Start with a template and closing modal I end up with this
Screenshot 2024-06-10 at 13 40 47
  1. New empty project and polling for status is bugged
Screenshot 2024-06-10 at 13 41 18 Screenshot 2024-06-10 at 13 41 12
  1. Should this be so weird
Screenshot 2024-06-10 at 13 43 06
  1. Tooltips problem
    https://github.com/enso-org/enso/assets/2855109/db6802ae-ded6-4b8d-b7ec-f5a96985ae9c

  2. Show secret value is not aligned and doesn't work

Screenshot 2024-06-10 at 13 44 56
  1. Share with modal
Screenshot 2024-06-10 at 13 46 05
  1. Have we disabled cmd / shift + arrows multiple selection?

@somebody1234
Copy link
Collaborator Author

uhoh

@somebody1234
Copy link
Collaborator Author

fixed some things locally, some of them are still TODO:

  1. fixed, assuming the issue is the focus ring being cut off
  • i've noticed the focus ring is inconsistent (spacing, animations) - this should probably be fixed at some point as well
  1. TODO
  2. fixed
  3. fixed, assuming the issue is the positioning causing issues
  4. fixed
  5. fixed
  6. (debugging TODO) idts - but it seems to be bugged, i can see the selection flashing for a moment before being reset to just the one row

@PabloBuchu
Copy link
Contributor

@somebody1234 we can fix 7th on separate PR and then just fix 2nd issue here. Then we can push this to merge after all others are fixed

@somebody1234 somebody1234 requested review from MrFlashAccount and removed request for MrFlashAccount June 10, 2024 13:54
@somebody1234
Copy link
Collaborator Author

found the cause of 2nd, was me being silly. @PabloBuchu should be ready for re-QA now - although now's probably not the best time, lol

@somebody1234
Copy link
Collaborator Author

@MrFlashAccount just a note that this PR is blocked on your re-review

@PabloBuchu
Copy link
Contributor

QA passed. I created one small fix https://github.com/enso-org/cloud-v2/issues/1301

lets fix the merge conflict and try to merge it today

@MrFlashAccount can you rereview and approve?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. g-dashboard x-new-feature Type: new feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the Dashboard to Newest Design
3 participants