-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Connector to Datalinks #9948
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR ✅, QA not done (it's late here)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its Datalink not Data Link so the camel case format is datalink
app/ide-desktop/lib/dashboard/src/services/remoteBackendPaths.ts
Outdated
Show resolved
Hide resolved
@PabloBuchu renamed, please take a look once again. @somebody1234 I didn't touch the DataLink schema fields, not sure we can safely touch it |
we don't need to touch the DataLink schema right? i assume it's safe to rename the variant names as well - libs doesn't appear to depend on the JSON Schema file: |
you should probably update the path in codeowners though ( Line 50 in a5ca9f9
|
Oh, yeah, thanks for noticing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably need a similar PR renaming the usages in our libs. I was always calling it Data Link
as I was not aware of any 'official' spelling.
Pull Request Description
Tl;dr
Closes: enso-org/cloud-v2#1132
This PR renames Connector to Datalink
Test Plan:
Everything should work as before, but instead of sending
connectorId
we senddataLinkId
and endpoint now is/datalink
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.