Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Connector to Datalinks #9948

Merged
merged 3 commits into from
May 20, 2024
Merged

Conversation

MrFlashAccount
Copy link
Contributor

@MrFlashAccount MrFlashAccount commented May 14, 2024

Pull Request Description

Tl;dr 

Closes: enso-org/cloud-v2#1132
This PR renames Connector to Datalink


Test Plan:

Everything should work as before, but instead of sending connectorId we send dataLinkId and endpoint now is /datalink


Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@MrFlashAccount MrFlashAccount self-assigned this May 14, 2024
@MrFlashAccount MrFlashAccount added CI: No changelog needed Do not require a changelog entry for this PR. x-chore Type: chore labels May 14, 2024
Copy link
Collaborator

@somebody1234 somebody1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ✅, QA not done (it's late here)

Copy link
Contributor

@PabloBuchu PabloBuchu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its Datalink not Data Link so the camel case format is datalink

app/ide-desktop/lib/dashboard/src/services/Backend.ts Outdated Show resolved Hide resolved
app/ide-desktop/lib/dashboard/src/services/Backend.ts Outdated Show resolved Hide resolved
@MrFlashAccount
Copy link
Contributor Author

MrFlashAccount commented May 17, 2024

@PabloBuchu renamed, please take a look once again.

@somebody1234 I didn't touch the DataLink schema fields, not sure we can safely touch it

@somebody1234
Copy link
Collaborator

didn't touch the DataLink schema fields

we don't need to touch the DataLink schema right?
but if it's just the descriptions then it should be fine. we definitely don't want to be changing the actual shape otherwise the generated JSON will no longer be valid inputs for libs.

i assume it's safe to rename the variant names as well - libs doesn't appear to depend on the JSON Schema file:
https://github.com/search?q=repo%3Aenso-org%2Fenso+dataLinkSchema&type=code

@somebody1234
Copy link
Collaborator

you should probably update the path in codeowners though (dataLink -> datalink):

/app/ide-desktop/lib/dashboard/src/data/dataLinkSchema.json @radeusgd @jdunkerley @GregoryTravis @AdRiley

@MrFlashAccount
Copy link
Contributor Author

you should probably update the path in codeowners though (dataLink -> datalink):

Oh, yeah, thanks for noticing!

@MrFlashAccount MrFlashAccount changed the title Rename Connector to DataLinks Rename Connector to Datalinks May 17, 2024
Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need a similar PR renaming the usages in our libs. I was always calling it Data Link as I was not aware of any 'official' spelling.

@MrFlashAccount MrFlashAccount added the CI: Ready to merge This PR is eligible for automatic merge label May 20, 2024
@mergify mergify bot merged commit 55d43a3 into develop May 20, 2024
37 checks passed
@mergify mergify bot deleted the wip/sergeigarin/rename-connector branch May 20, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge x-chore Type: chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants